Details on add guest os optional#7812
Merged
DaanHoogland merged 1 commit intoapache:4.18from Aug 4, 2023
Merged
Conversation
DaanHoogland
force-pushed
the
detailsOnAddGuestOs
branch
from
0b05864 to
a2e5b1a
Compare
Contributor
Author
|
@blueorangutan package |
|
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6650 |
Codecov Report
@@ Coverage Diff @@
## 4.18 #7812 +/- ##
============================================
- Coverage 13.02% 13.02% -0.01%
+ Complexity 9031 9029 -2
============================================
Files 2720 2720
Lines 257010 257010
Branches 40083 40083
============================================
- Hits 33472 33467 -5
- Misses 219336 219342 +6
+ Partials 4202 4201 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
I don't think this will be touched by any smoke tests |
BryanMLima
approved these changes
Aug 3, 2023
Contributor
BryanMLima
left a comment
BryanMLima
left a comment
There was a problem hiding this comment.
LGTM, already manually tested this change with PR #6979.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a issue reported in the user mail list: https://lists.apache.org/thread/clsoyz3kgp47ppbhtqp8m0o2fkczqrmk
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?